Skip to content
This repository has been archived by the owner on Feb 17, 2024. It is now read-only.

4.0 dev #209

Merged
merged 3 commits into from
Sep 23, 2023
Merged

4.0 dev #209

merged 3 commits into from
Sep 23, 2023

Conversation

oxyroid
Copy link
Contributor

@oxyroid oxyroid commented Sep 23, 2023

  1. I think release signingConfig in debug build type is useless, others cannot contribute this project because they did not have correct keystore.properites file.
  2. Use Default Expressions, see this.

@HuanCheng65
Copy link
Owner

Maybe as #190, fallback to debug signing when keystore.properites is not available

@HuanCheng65
Copy link
Owner

Using the same signature on the debug package as the release package is to facilitate coverage and installation during testing (there is a big performance difference between the debug package and the release package of Jetpack Compose, so sometimes it is necessary to test under release)

@oxyroid
Copy link
Contributor Author

oxyroid commented Sep 23, 2023

Alright, I can revert that line of code, but I recommend either switching to a different build variant or creating a new one tailored for this specific case.

Copy link
Contributor Author

@oxyroid oxyroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decomposed a Composable into multiple Composable functions to reduce unnecessary recomposition, removed unnecessary "remember", and merged Background and Surface components.

@HuanCheng65 HuanCheng65 merged commit 2b3dd20 into HuanCheng65:4.0-dev Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants