run in kfp folder

Signed-off-by: Maroun Touma <[email protected]>
IBM · Dec 18, 2024 · fe2eaa3 · fe2eaa3
1 parent 375bddd
commit fe2eaa3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/.github/workflows/test-universal-doc_id-kfp.yml b/.github/workflows/test-universal-doc_id-kfp.yml
@@ -101,14 +101,10 @@ jobs:
               timeout-minutes: 120
               run: |
                   KFP_BLACK_LIST=$(./scripts/check-workflows.sh -show-kfp-black-list)
-                  if [ -e "transforms/universal/doc_id/Makefile" -a -e "transforms/universal/doc_id/kfp_ray/Makefile" ]; then
-                     transform=$(basename "transforms/universal/doc_id")
-                     if echo ${KFP_BLACK_LIST} | grep -qv ${transform}; then
-                        $PWD/scripts/workflow_helper.sh install-tools
-                        $PWD/scripts/workflow_helper.sh test-workflow transforms/universal/doc_id   
-                     else
-                        $PWD/scripts/workflow_helper.sh build-workflow transforms/universal/doc_id
-                     fi              
+                  transform=$(basename "transforms/universal/doc_id")
+                  if echo ${KFP_BLACK_LIST} | grep -qv ${transform}; then
+                    $PWD/scripts/workflow_helper.sh install-tools
+                    $PWD/scripts/workflow_helper.sh test-workflow transforms/universal/doc_id
                   else
-                     echo "Skipping transforms/universal/doc_id kfp test for lack of Makefile and/or kfp_ray/Makefile"
-                   fi
+                    $PWD/scripts/workflow_helper.sh build-workflow transforms/universal/doc_id
+                  fi
diff --git a/transforms/.make.cicd.targets b/transforms/.make.cicd.targets
@@ -176,28 +176,28 @@ setup:: .transforms.setup
 
 kind-load-image:: .transforms.kind-load-image
 
-.PHONY: workflow-vent
+.PHONY: workflow-venv
 workflow-venv:
 	if [ -e kfp_ray ]; then                 \
-	    $(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-venv;   \
+	    cd kfp_ray && $(MAKE) TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-venv;   \
 	fi
 
 .PHONY: workflow-test
 workflow-test:
 	if [ -e kfp_ray ]; then                 \
-	    $(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-test;   \
+	    cd kfp_ray && $(MAKE) TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-test;   \
 	fi
 
 .PHONY: workflow-upload
 workflow-upload:
 	if [ -e kfp_ray ]; then                 \
-	    $(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-upload; \
+	    cd kfp_ray && $(MAKE) TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-upload; \
 	fi
 
 .PHONY: workflow-build
 workflow-build:
 	if [ -e kfp_ray ]; then                 \
-	    $(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-build; \
+		cd kfp_ray && $(MAKE) TRANSFORM_NAME=$(TRANSFORM_NAME) kfp-workflow-build; \
 	fi