Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html2parquet Moved to language folder #615

Merged
merged 5 commits into from
Sep 26, 2024
Merged

html2parquet Moved to language folder #615

merged 5 commits into from
Sep 26, 2024

Conversation

sungeunan-ibm
Copy link
Collaborator

Why are these changes needed?

As @daw3rd and @Bytes-Explorer suggested, moved html2parquet to language folder.

Related issue number (if any).

[Feature] Add support to process HTML file format #161

Signed-off-by: Sungeun An <[email protected]>
@daw3rd
Copy link
Member

daw3rd commented Sep 23, 2024

@sungeunan-ibm you will need to create a new set of workflows in .github/workflows.

cd .github/workflows
rm test-universal-html2parquet.yml 
make

to create (all) the transform workflows again, including the new one. This should create a new test-language-html2parquet.yml. This will then cause ci/cd PRs to

  1. run tests on the moved transform and
  2. pass the miscellaneous/check-transform-test-workflows.

Fingers crossed.

@touma-I
Copy link
Collaborator

touma-I commented Sep 26, 2024

@sungeunan-ibm I made the necessary changes to the CI/CD. @daw3rd or @shahrokhDaijavad Please review and approve so we can merge it once the checks complete. @sungeunan-ibm if you need to continue to work on the branch, you will need to do a git pull so you receive all the changes I Made. Thanks.

Copy link
Member

@daw3rd daw3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daw3rd daw3rd merged commit bb31e4c into dev Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants