Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed doc_text into contents in related files #663

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

ian-cho
Copy link
Collaborator

@ian-cho ian-cho commented Oct 3, 2024

The column name doc_text is changed into contents in all relevant scripts and parquet files

Why are these changes needed?

correct column name to be in line with other module.

Related issue number (if any).

#659

The column name `doc_text` is changed into `contents` in all relevant scripts and parquet files
@touma-I touma-I self-requested a review October 3, 2024 18:31
Copy link
Collaborator

@touma-I touma-I left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ian-cho - This is good work. Thank you. merging it now.

@touma-I touma-I merged commit 1fd9dba into dev Oct 3, 2024
6 checks passed
@touma-I touma-I deleted the ian-cho-patch-2 branch October 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants