Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Title Type class and properties #121

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Added Title Type class and properties #121

merged 9 commits into from
Oct 10, 2024

Conversation

ivozandhuis
Copy link
Contributor

See: #119

Before merging:

  • I did not bump the version number yet, so you are able to recognize the changes more easily. If you think my changes are good, you could decide to bump the version in an additional commit on the branch before merging.
  • I've made the French and Spanish translations of the labels based on other labels. Is this good enough?

@florenceclavaud florenceclavaud changed the base branch from master to version_1-1 October 4, 2024 11:32
florenceclavaud
florenceclavaud approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@florenceclavaud florenceclavaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done a few small changes (mainly in the French or Spanish labels). Now everything is OK and this can be merged.

@florenceclavaud florenceclavaud added this to the RiC-0 1.1 milestone Oct 10, 2024
@ivozandhuis ivozandhuis merged commit bd25c62 into version_1-1 Oct 10, 2024
2 checks passed
@ivozandhuis
Copy link
Contributor Author

@florenceclavaud thanks!

@ivozandhuis ivozandhuis deleted the feature/title-type branch October 10, 2024 15:44
@florenceclavaud florenceclavaud mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florenceclavaud florenceclavaud florenceclavaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
RiC-0 1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ivozandhuis @florenceclavaud