Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/migrate to gh #2263

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Feature/migrate to gh #2263

merged 4 commits into from
Sep 13, 2024

Conversation

thenav56
Copy link
Member

@thenav56 thenav56 commented Sep 13, 2024 •
edited
Loading

Addresses

Changes

  • Use profile in docker-compose.yml
  • Migrate CI from CircleCI to GitHub actions
  • Run CI before helm building and pushing action
  • Remove docker image push to docker hub

Post actions

  • Disable Circle CI

@thenav56 thenav56 force-pushed the feature/migrate-to-gh branch 5 times, most recently from bed9db9 to f880f32 Compare September 13, 2024 09:17
@thenav56
Use profile in docker-compose.yml
45fc878 
- docker compose up will only run essential services
- docker compose up run --rm <service-name> can be used to run cli
  helpers
- docker compose --profile elasticsearch up is required to run kibana
@thenav56 thenav56 force-pushed the feature/migrate-to-gh branch 3 times, most recently from 5b75639 to d83f3ae Compare September 13, 2024 09:57
@thenav56 thenav56 force-pushed the feature/migrate-to-gh branch from d83f3ae to c6c6486 Compare September 13, 2024 10:25
@thenav56 thenav56 marked this pull request as ready for review September 13, 2024 11:35
szabozoltan69
szabozoltan69 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@szabozoltan69 szabozoltan69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I will love that profile feature for local development!

@szabozoltan69 szabozoltan69 merged commit 74b6305 into develop Sep 13, 2024
2 of 3 checks passed
@szabozoltan69 szabozoltan69 deleted the feature/migrate-to-gh branch September 13, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabozoltan69 szabozoltan69 szabozoltan69 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Awaiting requested review from Rup-Narayan-Rajbanshi

@susilnem susilnem Awaiting requested review from susilnem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thenav56 @szabozoltan69