Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better formulation to wrap-up #784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

better formulation to wrap-up #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python_scripts/cross_validation_time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,5 +220,5 @@
# %% [markdown]
# In conclusion, it is really important to not use an out of the shelves
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "out of the shelves" is grammatically correct nor a common term for the students to know. Maybe we can rephrase the whole paragraph.

# cross-validation strategy which do not respect some assumptions such as having
# i.i.d data. It might lead to absurd results which could make think that a
# predictive model might work.
# i.i.d data. It might lead to absurd results. These absurd results can make you
# think that a predictive model might work while it is not doing so in practice.
Comment on lines +223 to +224
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# i.i.d data. It might lead to absurd results. These absurd results can make you
# think that a predictive model might work while it is not doing so in practice.
# i.i.d data. It might lead misleading outcomes, creating the false impression
# that a predictive model performs well when it may not be the case in the
# intended real-world scenario.

Loading