Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Handle no matching output for Include Table group #718

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

nguyen-v
Copy link

This PR fixes an error that was introduced with PR #707. When a group is defined with an output that is not given to the Include Table preflight, the following error was raised:

out, csv = out_to_csv_mapping.get(group_suffix)
    ^^^^^^^^
TypeError: cannot unpack non-iterable NoneType object

which is fixed by first checking if out_to_csv_mapping.get(group_suffix) is None.

@set-soft
Copy link
Member

Hi @nguyen-v !
Please rebase the patch so it includes only the last commit.
Also: I think a better solution is to just use out, csv = out_to_csv_mapping.get(group_suffix, (None, None))

@nguyen-v nguyen-v force-pushed the fix_inc_table_csv_mapping branch from dc2c197 to 11fb946 Compare November 13, 2024 13:42
@nguyen-v
Copy link
Author

Please rebase the patch so it includes only the last commit.
Also: I think a better solution is to just use out, csv = out_to_csv_mapping.get(group_suffix, (None, None))

Just rebased to dev with your suggestion

@set-soft set-soft merged commit 300dac9 into INTI-CMNB:dev Nov 13, 2024
17 checks passed
@nguyen-v nguyen-v deleted the fix_inc_table_csv_mapping branch November 13, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants