Fix correlation_matrix issue 105 and test #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
Jan 6, 2025
| @@ -962,6 +962,9 @@ end | |||
| @test inner(psi', MPO(a, s), psi) ≈ Cpm[i - ss + 1, j - ss + 1] | |||
| end | |||
|
|
|||
| # Test sites argument (also regression test for issue #105) | |||
| Cxz = correlation_matrix(psi, "X", "Z"; sites=2:2:6) | |||
There was a problem hiding this comment.
Can you check the result using test_correlation_matrix? It might not handle the sites keyword argument properly right now but that should be easy to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in mps.jl, line 899, pointed out by dhqian in issue #105. Add a line to test_mps.jl that triggers this issue if not fixed.