Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Pass eigen_perturbation properly to factorize_eigen #1240

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

mtfishman
Copy link
Member

Fixes #1239.

Also improves keyword argument style in dmrg.

@mtfishman
Copy link
Member Author

[test ITensors mps]

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/6777505021

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/6777505021

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2dd057b) 54.56% compared to head (00d0075) 54.58%.

❗ Current head 00d0075 differs from pull request most recent head 4fa2c6b. Consider uploading reports for the commit 4fa2c6b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
+ Coverage   54.56%   54.58%   +0.02%     
==========================================
  Files          88       88              
  Lines        8392     8376      -16     
==========================================
- Hits         4579     4572       -7     
+ Misses       3813     3804       -9     
Files Coverage Δ
src/tensor_operations/matrix_decomposition.jl 89.93% <100.00%> (+1.00%) ⬆️
src/mps/dmrg.jl 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member Author

[test ITensors mps]

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/6778552062

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/6778552062

@mtfishman
Copy link
Member Author

[test ITensors mps]

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/6778738521

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/6778738521

@mtfishman
Copy link
Member Author

[test ITensors mps]

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6785232602

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6785232602

@mtfishman mtfishman merged commit caba420 into main Nov 7, 2023
7 checks passed
@mtfishman mtfishman deleted the ITensors_noise_term_fix branch November 7, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ITensors] [BUG] factorization in current ITensors version does not use eigen_perturbation
2 participants