Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlockSparseArrays] Sparse and block sparse matrix multiplication #1278

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Dec 5, 2023

This adds support for sparse and block sparse matrix multiplication.

TODO:

  • Test matrix multiplication of DiagonalArray and SparseArrayDOK.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ff3110) 84.03% compared to head (888512f) 53.82%.

❗ Current head 888512f differs from pull request most recent head a905a69. Consider uploading reports for the commit a905a69 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1278       +/-   ##
===========================================
- Coverage   84.03%   53.82%   -30.22%     
===========================================
  Files         100       99        -1     
  Lines        8540     8487       -53     
===========================================
- Hits         7177     4568     -2609     
- Misses       1363     3919     +2556     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit 27b157e into main Dec 5, 2023
7 checks passed
@mtfishman mtfishman deleted the SparseArrayInterface_mul branch December 5, 2023 17:28
@emstoudenmire
Copy link
Collaborator

Great. Does this already use the sparse tensor type in the way you were saying, with the 'elements' being dense tensors/matrices?

@mtfishman
Copy link
Member Author

Yeah, that's been the design of the BlockSparseArray type in the BlockSparseArrays library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants