Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Update CI testing and package versions #1281

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented Dec 6, 2023

Description

CI uses out of data packages which can lead to error in testing suite.

Checklist:

  • Update Jenkins to Julia 1.9
  • Make sure all tests pass with up to date Zygote
  • Chainrules test fail for lower Julia versions, understand what Zygote version causes break

with regard to the last point. [email protected] works in Julia versions below v"1.8" it would appear the the breaking change in Zygote is in the 0.6.61 update

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27b157e) 84.05% compared to head (11968cb) 53.92%.

❗ Current head 11968cb differs from pull request most recent head 12535dc. Consider uploading reports for the commit 12535dc to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1281       +/-   ##
===========================================
- Coverage   84.05%   53.92%   -30.13%     
===========================================
  Files         100       99        -1     
  Lines        8540     8487       -53     
===========================================
- Hits         7178     4577     -2601     
- Misses       1362     3910     +2548     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title [Debug][ITensors] Update CI testing and package versions [ITensors] Update CI testing and package versions Dec 7, 2023
@mtfishman
Copy link
Member

Thanks! Ready to merge?

@kmp5VT
Copy link
Collaborator Author

kmp5VT commented Dec 7, 2023

Thanks! Ready to merge?

Ah yes, thanks!

@mtfishman mtfishman merged commit b25c5fe into ITensor:main Dec 7, 2023
7 checks passed
@kmp5VT kmp5VT deleted the kmp5/debug/ci branch December 8, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants