-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TensorAlgebra] Refactor contract
#1290
Conversation
NDTensors/src/lib/NamedDimsArrays/ext/NamedDimsArraysTensorAlgebraExt/src/qr.jl
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
===========================================
- Coverage 84.05% 53.94% -30.12%
===========================================
Files 100 99 -1
Lines 8542 8489 -53
===========================================
- Hits 7180 4579 -2601
- Misses 1362 3910 +2548 ☔ View full report in Codecov by Sentry. |
NDTensors/src/lib/NamedDimsArrays/ext/NamedDimsArraysTensorAlgebraExt/src/fusedims.jl
Outdated
Show resolved
Hide resolved
NDTensors/src/lib/NamedDimsArrays/ext/NamedDimsArraysTensorAlgebraExt/test/runtests.jl
Outdated
Show resolved
Hide resolved
[test ITensors mps] |
Run ITensors mps tests from comment trigger: succeeded ✅ |
Run ITensors mps tests from comment trigger: succeeded ✅ |
This refactors the
contract
function inTensorAlgebra
based on refactoredfusedims
andsplitdims
functions for matricizing and unmatricizing.It is based around a
BlockedPermutation
object which represents a permutation such as(2, 1, 4, 3)
which is blocked or partitioned into parts, such as((2, 1), (4, 3))
. That is used to specify which dimensions of an array should get grouped together when performing a matricization of an n-dimensional array.Basically ready, I still need to update definitions of
fusedims
andsplitdims
forNamedDimsArray
where dimension names are used to specify matricization/dimension fusion.