Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorAlgebra] Refactor contract #1290

Merged
merged 10 commits into from
Dec 22, 2023
Merged

[TensorAlgebra] Refactor contract #1290

merged 10 commits into from
Dec 22, 2023

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Dec 17, 2023

This refactors the contract function in TensorAlgebra based on refactored fusedims and splitdims functions for matricizing and unmatricizing.

It is based around a BlockedPermutation object which represents a permutation such as (2, 1, 4, 3) which is blocked or partitioned into parts, such as ((2, 1), (4, 3)). That is used to specify which dimensions of an array should get grouped together when performing a matricization of an n-dimensional array.

Basically ready, I still need to update definitions of fusedims and splitdims for NamedDimsArray where dimension names are used to specify matricization/dimension fusion.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (faa0357) 84.05% compared to head (027967c) 53.94%.
Report is 4 commits behind head on main.

❗ Current head 027967c differs from pull request most recent head 0368198. Consider uploading reports for the commit 0368198 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1290       +/-   ##
===========================================
- Coverage   84.05%   53.94%   -30.12%     
===========================================
  Files         100       99        -1     
  Lines        8542     8489       -53     
===========================================
- Hits         7180     4579     -2601     
- Misses       1362     3910     +2548     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman marked this pull request as ready for review December 22, 2023 19:43
@mtfishman
Copy link
Member Author

[test ITensors mps]

Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/7303340976

@mtfishman mtfishman merged commit 73dff5b into main Dec 22, 2023
9 of 10 checks passed
@mtfishman mtfishman deleted the NamedDimsArrays_contract branch December 22, 2023 20:07
Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/7303340976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants