This repository has been archived by the owner on Mar 20, 2019. It is now read-only.
Token cleanup isn't performing very well with large amounts of data #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder to improve performance
|
@brockallen @leastprivilege @scottbrady91 Is this something you'd consider including please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Poor token cleanup performance
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
I noticed that the select query being generated by EntityFrameworkCore starts timing out more as more data is inserted into the PersistedGrants table. I'm not exactly sure why the costly "OrderBy" method is needed here, since it shouldn't matter what order the expired tokens are deleted in.