Small attempt at fixing HomePage Lag

Iliano101 · Nov 3, 2024 · ce80149 · ce80149
1 parent 9520ecd
commit ce80149
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/app/src/main/java/com/maxrave/simpmusic/data/db/entities/SongEntity.kt b/app/src/main/java/com/maxrave/simpmusic/data/db/entities/SongEntity.kt
@@ -6,7 +6,7 @@ import com.maxrave.simpmusic.common.DownloadState.STATE_NOT_DOWNLOADED
 import java.time.LocalDateTime
 
 @Entity(tableName = "song")
-data class SongEntity (
+data class SongEntity(
     @PrimaryKey(autoGenerate = false) val videoId: String = "",
     val albumId: String? = null,
     val albumName: String? = null,
@@ -26,8 +26,7 @@ data class SongEntity (
     val totalPlayTime: Long = 0, // in milliseconds
     val downloadState: Int = STATE_NOT_DOWNLOADED,
     val inLibrary: LocalDateTime = LocalDateTime.now(),
-    )
-{
+) {
     fun toggleLike() = copy(liked = !liked)
 
 }
diff --git a/app/src/main/java/com/maxrave/simpmusic/data/model/browse/album/AlbumBrowse.kt b/app/src/main/java/com/maxrave/simpmusic/data/model/browse/album/AlbumBrowse.kt
@@ -1,10 +1,12 @@
 package com.maxrave.simpmusic.data.model.browse.album
 
 
+import androidx.compose.runtime.Immutable
 import com.google.gson.annotations.SerializedName
 import com.maxrave.simpmusic.data.model.searchResult.songs.Artist
 import com.maxrave.simpmusic.data.model.searchResult.songs.Thumbnail
 
+@Immutable
 data class AlbumBrowse(
     @SerializedName("artists")
     val artists: List<Artist>,

diff --git a/app/src/main/java/com/maxrave/simpmusic/data/model/browse/album/Track.kt b/app/src/main/java/com/maxrave/simpmusic/data/model/browse/album/Track.kt
@@ -1,12 +1,14 @@
 package com.maxrave.simpmusic.data.model.browse.album
 
 
+import androidx.compose.runtime.Immutable
 import com.google.gson.annotations.SerializedName
 import com.maxrave.simpmusic.data.model.searchResult.songs.Album
 import com.maxrave.simpmusic.data.model.searchResult.songs.Artist
 import com.maxrave.simpmusic.data.model.searchResult.songs.FeedbackTokens
 import com.maxrave.simpmusic.data.model.searchResult.songs.Thumbnail
 
+@Immutable
 data class Track(
     @SerializedName("album")
     val album: Album?,

diff --git a/app/src/main/java/com/maxrave/simpmusic/data/model/home/HomeItem.kt b/app/src/main/java/com/maxrave/simpmusic/data/model/home/HomeItem.kt
@@ -1,9 +1,11 @@
 package com.maxrave.simpmusic.data.model.home
 
 
+import androidx.compose.runtime.Immutable
 import com.google.gson.annotations.SerializedName
 import com.maxrave.simpmusic.data.model.searchResult.songs.Thumbnail
 
+@Immutable
 data class HomeItem(
     @SerializedName("contents")
     val contents: List<Content?>,

diff --git a/app/src/main/java/com/maxrave/simpmusic/ui/screen/home/HomeScreen.kt b/app/src/main/java/com/maxrave/simpmusic/ui/screen/home/HomeScreen.kt
@@ -286,7 +286,7 @@ fun HomeScreen(
                                 )
                             }
                         }
-                        items(homeData) {
+                        items(homeData, key = { it.title + it.channelId }) {
                             if (it.title != context.getString(R.string.quick_picks)) {
                                 HomeItem(
                                     homeViewModel = viewModel,
@@ -296,7 +296,7 @@ fun HomeScreen(
                                 )
                             }
                         }
-                        items(newRelease) {
+                        items(newRelease, key = { it.title + it.channelId }) {
                             androidx.compose.animation.AnimatedVisibility(
                                 visible = newRelease.isNotEmpty(),
                             ) {