When a render (from gaffer) is paused and restarted, we get a new asr…

[robpieke]

When camera parameters are updated in Gaffer, we get a new asr::Frame/asf::Image, but don't currently recognise it. This change should resolve #730

[est77]

Thanks for the report and for the PR.

I think that the real bug is on the Gaffer side. Changing camera parameters should not recreate the Frame.
Let me check it quickly.

Thanks!

[robpieke]

Thanks Esteban! I'm very new to both codebases, so I'll be quite interested to see where you think the issue is actually best addressed!

[est77]

I am pretty sure that we should not create a new frame during interactive rendering.
We don't support changing the image resolution or AOVs during interactive rendering
and that's the only reason to recreate the frame.

I'll try to reproduce the crash and open a PR with the fix in Gaffer.

Thanks!

[johnhaddon]

Thanks for tracking this one down Rob, and for the PR. This is @est77's area of expertise rather than mine so I'll defer to you both on what the final solution should be...

We don't support changing the image resolution or AOVs during interactive rendering
and that's the only reason to recreate the frame.

Would be great to lift this limitation, whether in Appleseed itself or via some workaround in Gaffer/Cortex. Think raytraced viewports...

Cheers...
John

[est77]

I can confirm it is a bug in GafferAppleseed. I'll push a fix soon.
In the meantime, we can close this PR.

I'll check with the rest of the team about interactive image resolution edits.

[johnhaddon]

OK, closing. Thanks for tracking this down Rob. Any idea when you'll have a chance to make the Gaffer-side fix @est77?

[est77]

I was planning to do it this weekend.

[johnhaddon]

Great! Thanks!