Fix patch mark test

backend/langate/network/tests.py

@@ -591,8 +591,9 @@ def test_get_marks(self, mock_settings):
             self.assertEqual(response.data[i]["devices"], Device.objects.filter(mark=self.settings["marks"][i]["value"], whitelisted=False).count())
             self.assertEqual(response.data[i]["whitelisted"], Device.objects.filter(mark=self.settings["marks"][i]["value"], whitelisted=True).count())
 
+    @patch('langate.settings.netcontrol.set_mark', return_value=None)
     @patch('langate.network.views.save_settings')
-    def test_patch_marks(self, mock_save_settings):
+    def test_patch_marks(self, mock_save_settings, mock_set_mark):
         mock_save_settings.side_effect = lambda x: None
 
         new_marks = [
@@ -603,7 +604,7 @@ def test_patch_marks(self, mock_save_settings):
 
         from langate.settings import SETTINGS as ORIGINAL_SETTINGS
 
-        self.assertEqual(response.status_code, status.HTTP_201_CREATED)
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
         self.assertEqual(len(ORIGINAL_SETTINGS["marks"]), 2)
         self.assertEqual(ORIGINAL_SETTINGS["marks"][0]["value"], 102)
         self.assertEqual(ORIGINAL_SETTINGS["marks"][1]["value"], 103)

backend/langate/network/views.py

@@ -329,6 +329,7 @@ def patch(self, request):
         removed_marks = [m for m in old_marks if m not in new_marks]
 
         SETTINGS["marks"] = marks
+        save_settings(SETTINGS)
 
         if removed_marks:
             for mark in removed_marks:
@@ -337,8 +338,6 @@ def patch(self, request):
                     new = get_mark(excluded_marks=[mark])
                     DeviceManager.edit_device(device, device.mac, device.name, new)
 
-        save_settings(SETTINGS)
-
         return Response(SETTINGS["marks"], status=status.HTTP_200_OK)
 
 class MarkMove(APIView):