Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "entity-change-block" flag check for roads #4527

Conversation

RedstoneFuture
Copy link
Member

@RedstoneFuture RedstoneFuture commented Oct 23, 2024

Overview

This PR adds the check and restriction for wall/roads in case of EntityChangeBlock events. The used PS flag is still entity-change-block.

Fixes #4524

Description

I don't understand why the road flag is not observed at this point. It is necessary so that the default value “false” of the flag or the configured flag setting is taken into account.

The road flags should actually be validated and completed for all events, but here is the fix for the linked issue.

Submitter Checklist

Preview Give feedback

@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 23, 2024
@RedstoneFuture RedstoneFuture marked this pull request as ready for review October 23, 2024 16:28
@RedstoneFuture RedstoneFuture requested a review from a team as a code owner October 23, 2024 16:28
@RedstoneFuture RedstoneFuture changed the title Adding check for plot flag Adding "entity-change-block" flag check for roads Oct 23, 2024
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dordsor21 dordsor21 merged commit a42e08d into IntellectualSites:main Nov 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

road-flags doesn't work
3 participants