Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR #669 #717

Conversation

mohamedawnallah
Copy link
Member

@mohamedawnallah mohamedawnallah commented Dec 30, 2023

Description

Happy New Year everyone 🎄 I'm glad to submit a pull request that addresses the following regression issues caused by Vue js 3 Migration PR #669 :

  1. Regression in Date-Time Filtering in Global Report post vue.js 3 migration #721
  2. Regression in Group by alternative keys mechanism in Global Report post vue.js 3 migration #722
  3. Regression in Severities filtering and its reactivity to the table data visualization in Global Report post vue.js 3 migration #723

In addition to resolving the main regression issues, it restores many functionalities implemented in #634.

How Has This Been Tested?

I made sure that all the functionalities work in Global Report V2 as expected in addition to this please check all the test cases passed in the GitHub CI job result:
https://github.com/InternetHealthReport/ihr-website/actions/runs/7371266038/job/20058467648

Recordings

pr-717.mov

Types of changes

  • Regression fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mohamedawnallah mohamedawnallah changed the title [regressions fix]: Address the global report regressions caused by Vue js 3 Migration [regressions fix]: Address the global report regressions caused by Vue js 3 Migration PR Dec 30, 2023
@dpgiakatos dpgiakatos mentioned this pull request Dec 31, 2023
6 tasks
@mohamedawnallah mohamedawnallah force-pushed the vuejs-3-migration-regressions-fix branch from 9ddbf18 to bcdc199 Compare December 31, 2023 15:12
@mohamedawnallah mohamedawnallah changed the title [regressions fix]: Address the global report regressions caused by Vue js 3 Migration PR [vue-js-3-migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR Dec 31, 2023
@mohamedawnallah mohamedawnallah changed the title [vue-js-3-migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR [migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR Dec 31, 2023
@mohamedawnallah mohamedawnallah changed the title [migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR [migration-regression-fixes]: Address the global report regressions caused by Vue js 3 Migration PR #669 Dec 31, 2023
@mohamedawnallah mohamedawnallah marked this pull request as ready for review December 31, 2023 17:28
@dpgiakatos dpgiakatos self-requested a review January 9, 2024 12:25
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request aims to resolve some issues on the global report v2 page after the migration to Vue 3.js. The author has addressed these issues, and the functionalities are working without errors. Therefore, this pull request can be merged into the master branch.

@romain-fontugne
Copy link
Member

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants