Fixed disconnect when output variable is chosen before "Load Graph" #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New variables can be selected without having to click "Load Graphs" first, by carrying over the "runs" var as r6$output instead of creating a new blank variable. This does cause the app to crash if a new SSP is selected after selecting new variables, though, so it's not a complete fix
…ad Graphs"" This reverts commit cf4de20.
Selecting a new output variable now draws the chosen SSP from the R6 class rather than the shiny input, ensuring that it uses the SSPs that were selected at the time "Load Graph" was last clicked (or when app was opened). This does impact plotting (and downloading data) -- when you change output variables, it will only plot one SSP and you have to click Load Graph to show both again.
Another update to the flow of selecting SSPs and parameters -- the app will no longer crash, but users will need to select Load Graphs when selecting new parameters or else only the first selected SSP will plot. Gets rid of disconnect issue (seemingly completely?) but does cause issue with plotting.
When a new output variable is selected, the SSPs/parameters selected the last time Load Graphs was clicked (or when the app loaded) will remain the same, until Load Graphs is clicked again.
Condensed line of code where vars are fetched when output variable is changed
stephpenn1
approved these changes
Sep 18, 2024
|
Hi Ciara, these changes look good, and all checks have passed. Thanks for the detailed PR description. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #77
The app disconnected if the selected SSPs were changed, then a new output variable was chosen (in that order). When trying to pull selected scenarios to plot when the output variable was changed, the app would take whichever SSPs were selected at that moment, rather than the ones that were actually used for the previous Hector run (i.e. it would try to fetch an output from a scenario that had not been run).
Solution:
After a Hector run (when the app first loads, or when Load Graphs is clicked), the scenario(s) for the run are stored in the R6 class. When the output variable is changed and that output is fetched from the core, the app now uses the selected scenario(s) from the R6 class rather than directly from the SSP input variable, making sure that the correct scenarios are used.
This PR closes #77