Removed some things for internal use from interfaces

JKorf · Oct 12, 2023 · 6ba32fe · 6ba32fe
1 parent f75cc75
commit 6ba32fe
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 42 deletions.
diff --git a/CryptoExchange.Net.UnitTests/TestImplementations/TestBaseClient.cs b/CryptoExchange.Net.UnitTests/TestImplementations/TestBaseClient.cs
@@ -60,11 +60,6 @@ public override void AuthenticateRequest(RestApiClient apiClient, Uri uri, HttpM
             headers = new Dictionary<string, string>();
         }
 
-        public override string Sign(string toSign)
-        {
-            return toSign;
-        }
-
         public string GetKey() => _credentials.Key.GetString();
         public string GetSecret() => _credentials.Secret.GetString();
     }

diff --git a/CryptoExchange.Net/Clients/BaseClient.cs b/CryptoExchange.Net/Clients/BaseClient.cs
@@ -52,7 +52,7 @@ protected BaseClient(ILoggerFactory? logger, string name)
         /// </summary>
         /// <param name="options"></param>
         /// <exception cref="ArgumentNullException"></exception>
-        public virtual void Initialize(ExchangeOptions options)
+        protected virtual void Initialize(ExchangeOptions options)
         {
             if (options == null)
                 throw new ArgumentNullException(nameof(options));

diff --git a/CryptoExchange.Net/Clients/SocketApiClient.cs b/CryptoExchange.Net/Clients/SocketApiClient.cs
@@ -563,7 +563,7 @@ protected void AddGenericHandler(string identifier, Action<MessageEvent> action)
         /// </summary>
         /// <param name="connection"></param>
         /// <returns></returns>
-        public virtual Task<Uri?> GetReconnectUriAsync(SocketConnection connection)
+        protected internal virtual Task<Uri?> GetReconnectUriAsync(SocketConnection connection)
         {
             return Task.FromResult<Uri?>(connection.ConnectionUri);
         }
@@ -573,7 +573,7 @@ protected void AddGenericHandler(string identifier, Action<MessageEvent> action)
         /// </summary>
         /// <param name="request">The original request</param>
         /// <returns></returns>
-        public virtual Task<CallResult<object>> RevitalizeRequestAsync(object request)
+        protected internal virtual Task<CallResult<object>> RevitalizeRequestAsync(object request)
         {
             return Task.FromResult(new CallResult<object>(request));
         }
@@ -683,7 +683,7 @@ protected virtual IWebsocket CreateSocket(string address)
         /// <param name="identifier">Identifier for the periodic send</param>
         /// <param name="interval">How often</param>
         /// <param name="objGetter">Method returning the object to send</param>
-        public virtual void SendPeriodic(string identifier, TimeSpan interval, Func<SocketConnection, object> objGetter)
+        protected virtual void SendPeriodic(string identifier, TimeSpan interval, Func<SocketConnection, object> objGetter)
         {
             if (objGetter == null)
                 throw new ArgumentNullException(nameof(objGetter));

diff --git a/CryptoExchange.Net/Interfaces/IRestApiClient.cs b/CryptoExchange.Net/Interfaces/IRestApiClient.cs
@@ -17,17 +17,5 @@ public interface IRestApiClient : IBaseApiClient
         /// Total amount of requests made with this API client
         /// </summary>
         int TotalRequestsMade { get; set; }
-
-        /// <summary>
-        /// Get time offset for an API client. Return null if time syncing shouldnt/cant be done
-        /// </summary>
-        /// <returns></returns>
-        TimeSpan? GetTimeOffset();
-
-        /// <summary>
-        /// Get time sync info for an API client. Return null if time syncing shouldnt/cant be done
-        /// </summary>
-        /// <returns></returns>
-        TimeSyncInfo? GetTimeSyncInfo();
     }
 }
diff --git a/CryptoExchange.Net/Interfaces/ISocketApiClient.cs b/CryptoExchange.Net/Interfaces/ISocketApiClient.cs
@@ -27,14 +27,6 @@ public interface ISocketApiClient: IBaseApiClient
         /// The factory for creating sockets. Used for unit testing
         /// </summary>
         IWebsocketFactory SocketFactory { get; set; }
-
-        /// <summary>
-        /// Get the url to reconnect to after losing a connection
-        /// </summary>
-        /// <param name="connection"></param>
-        /// <returns></returns>
-        Task<Uri?> GetReconnectUriAsync(SocketConnection connection);
-
         /// <summary>
         /// Log the current state of connections and subscriptions
         /// </summary>
@@ -45,19 +37,6 @@ public interface ISocketApiClient: IBaseApiClient
         /// <returns></returns>
         Task ReconnectAsync();
         /// <summary>
-        /// Update the original request to send when the connection is restored after disconnecting. Can be used to update an authentication token for example.
-        /// </summary>
-        /// <param name="request">The original request</param>
-        /// <returns></returns>
-        Task<CallResult<object>> RevitalizeRequestAsync(object request);
-        /// <summary>
-        /// Periodically sends data over a socket connection
-        /// </summary>
-        /// <param name="identifier">Identifier for the periodic send</param>
-        /// <param name="interval">How often</param>
-        /// <param name="objGetter">Method returning the object to send</param>
-        void SendPeriodic(string identifier, TimeSpan interval, Func<SocketConnection, object> objGetter);
-        /// <summary>
         /// Unsubscribe all subscriptions
         /// </summary>
         /// <returns></returns>