Fix gh 398 hash collision mitigation #408
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the temporary fix to mitigate hash collisions & added a new opt-in behavior for tracking instances using a concurrent dictionary & instance identifier struct.
The new optional
InstanceMapBehavior
has been added to the hosting extensions & container/scope constructors. The default value will maintain the integer-based hash approach. Passing aDictionary
value will update the tracked services implementation to use a concurrent dictionary in place of the hash map. When a dictionary is used, theInstanceIdentifier
struct will be tracked through itsIEquatable
implementation, rather than the hashcode.