Set up top level navigation #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsmb13
commented
Jan 18, 2025
androidApp/src/androidMain/kotlin/org/jetbrains/kotlinconf/android/MainActivity.kt
Outdated
Show resolved
Hide resolved
zsmb13
force-pushed
the
top-level-nav
branch
5 times, most recently
from
6a071b2 to
56937c2
Compare
kropp
requested changes
Jan 20, 2025
ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/MainNavigation.kt
Outdated
Show resolved
Hide resolved
androidApp/src/androidMain/kotlin/org/jetbrains/kotlinconf/android/MainActivity.kt
Outdated
Show resolved
Hide resolved
kropp
reviewed
Jan 20, 2025
Introduced new "filled" icon variants for navigation buttons to improve UI feedback when a destination is selected. Updated `MainNavDestination` and related components to support the new filled icons dynamically. Adjusted previews and logic to handle the selected state appropriately.
kropp
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236
This PR updates the navigation setup of the app the following way:
HomeScreencomponent serves the screen with 4-button bottom navigation between its destinations. This can't be a nested nav graph as there's also common UI that persists through the screens (the bottom navigation bar), so it's a destination that contains a secondNavHostthat navigates within theHomeScreendestinations.