Skip to content

Commit

Permalink
Merge #1584: Do not reinstall on test
Browse files Browse the repository at this point in the history
1cb20d5 Do not reinstall on test (roshii)

Pull request description:

  Removing `pip install .[test]` step from test script. It does not make sense to reinstall everything when test are ran especially with editable install.

ACKs for top commit:
  kristapsk:
    re-ACK 1cb20d5

Tree-SHA512: 7a35f1f7f2160b84e97819f0f91655c551e8343921f734a0092d3fdaad76d46afcf2f053ad55964120240314dced4557d55c44d299e4622a50b55851b4b5df73
  • Loading branch information
kristapsk committed Nov 5, 2023
2 parents 2e0b3a4 + 1cb20d5 commit bbb6dc1
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,6 @@ run_jm_tests ()
mkdir -p miniircd
tar -xzf miniircd.tar.gz -C ./miniircd --strip-components=1
fi
if ! pip install -e '.[test]'; then
echo "Joinmarket could not be installed. Exiting."
return 1
fi
if [[ ! -L ./joinmarket.cfg && -e ./joinmarket.cfg ]]; then
mv ./joinmarket.cfg ./joinmarket.cfg.bak
echo "file 'joinmarket.cfg' moved to 'joinmarket.cfg.bak'"
Expand Down

0 comments on commit bbb6dc1

Please sign in to comment.