Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphicsMagick] Build without profiler support #10186

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Jan 1, 2025

Trying to address #9887

@ViralBShah ViralBShah merged commit 563ae57 into master Jan 1, 2025
25 checks passed
@ViralBShah ViralBShah deleted the vs/graphicsmagick branch January 1, 2025 16:03
@ViralBShah
Copy link
Member Author

ViralBShah commented Jan 1, 2025

This package does not get registered

ERROR: Overlapping ranges for JLLWrappers for version 1.3.45+0 in registry.

Any idea why? JuliaRegistries/General#122252 (comment)

@giordano?

@giordano
Copy link
Member

giordano commented Jan 1, 2025

All new builds must change the version number, because JLLWrappers changes the compat bound

@ViralBShah
Copy link
Member Author

Don’t we do build triggers that just rebuild the binaries and add +1 and such to the name? Why is this case different?

@giordano
Copy link
Member

giordano commented Jan 2, 2025

With BinaryBuilder v0.6.2 we now always require JLLWrappers 1.7.0, this means that if the previous build had a different compat bound you MUST change the version number (I'm talking about the x.y.z part, not the build) unless you want to face the wrath of multiple people complaining about things breaking down, as I had to do last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants