[Reactant] Check CUDA version number in platform augmentation #10265
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Jan 13, 2025
R/Reactant/build_tarballs.jl
Outdated
| Base.include_dependency(path) | ||
| gpu = "cuda" | ||
| if cuda_version isa VersionNumber | ||
| if cuda_version == v"12.6" |
There was a problem hiding this comment.
@wsmoses I don't know what check you exactly want, but you can tweak it here.
There was a problem hiding this comment.
I think probably >= 12.6
We can also build different reactant versions for different cuda versions too
|
Uhm, sounds like EnzymeAD/Reactant.jl@eef65ce was a commit in EnzymeAD/Reactant.jl#497 which got squashed upon merging? 🫠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: EnzymeAD/Reactant.jl#526.