fix: fix time span settings with identical names colliding

Kageetai · Nov 28, 2023 · a6285a6 · a6285a6
1 parent 2571ceb
commit a6285a6
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 13 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "journal-review",
 	"name": "Journal Review",
-	"version": "2.0.7",
+	"version": "2.0.8",
 	"minAppVersion": "0.15.0",
 	"description": "Review your daily notes on their anniversaries, like \"what happened today last year\".",
 	"author": "Kageetai",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "obsidian-plugin-journal-review",
-	"version": "2.0.7",
+	"version": "2.0.8",
 	"description": "Review your daily notes on their anniversaries, like \"what happened today last year\"\n\n",
 	"main": "main.js",
 	"scripts": {

diff --git a/src/settingsTab.ts b/src/settingsTab.ts
@@ -45,20 +45,25 @@ export class SettingsTab extends PluginSettingTab {
 				const timeSpanContainer = container.createEl("li");
 
 				new Setting(timeSpanContainer)
-					.setName(getTimeSpanTitle({ number, unit, recurring }))
+					.setName(`Time span #${index + 1}`)
+					.setDesc(getTimeSpanTitle({ number, unit, recurring }))
 					.addSlider((slider) =>
 						slider
 							.setValue(number)
 							.setLimits(1, getMaxTimeSpan(unit), 1)
 							.setDynamicTooltip()
 							.onChange(
-								debounce((value) => {
-									this.plugin.settings.timeSpans[
-										index
-									].number = value;
-									this.plugin.saveSettings();
-									this.display();
-								}, DEBOUNCE_DELAY),
+								debounce(
+									(value) => {
+										this.plugin.settings.timeSpans[
+											index
+										].number = value;
+										this.plugin.saveSettings();
+										this.display();
+									},
+									DEBOUNCE_DELAY,
+									true,
+								),
 							),
 					)
 					.addDropdown((dropdown) =>

diff --git a/src/styles-settings.css b/src/styles-settings.css
@@ -17,5 +17,18 @@
 		gap: 1rem;
 		padding-top: 0;
 		border-top: none;
+
+		/* hide setting name */
+		& .setting-item-name {
+			display: none;
+		}
+
+		/* display description instead */
+		& .setting-item-description {
+			color: var(--text-normal);
+			font-size: var(--font-ui-medium);
+			padding-top: 0;
+			line-height: var(--line-height-normal);
+		}
 	}
 }
diff --git a/versions.json b/versions.json
@@ -10,5 +10,6 @@
 	"2.0.4": "0.15.0",
 	"2.0.5": "0.15.0",
 	"2.0.6": "0.15.0",
-	"2.0.7": "0.15.0"
+	"2.0.7": "0.15.0",
+	"2.0.8": "0.15.0"
 }