feat(Canvas): Use path+scope as VizNode ID
#1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
============================================
+ Coverage 78.62% 78.84% +0.22%
Complexity 365 365
============================================
Files 439 465 +26
Lines 14234 14570 +336
Branches 2769 2792 +23
============================================
+ Hits 11191 11488 +297
+ Misses 2954 2813 -141
- Partials 89 269 +180 ☔ View full report in Codecov by Sentry. |
lordrip
force-pushed
the
fix/ensure-viznode-id-2
branch
2 times, most recently
from
90f234f to
548d4fa
Compare
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 16, 2024
Currently, the component name is being used as the title in the `CanvasForm`. This commit uses the corresponding `Title` property if available from components, eips and kamelets, and the `ID` as a last resort. fix: KaotoIO#1462 prerequisite of: KaotoIO#1699
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 16, 2024
Currently, the component name is being used as the title in the `CanvasForm`. This commit uses the corresponding `Title` property if available from components, eips and kamelets, and the `ID` as a last resort. fix: KaotoIO#1462 prerequisite of: KaotoIO#1699
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 16, 2024
Currently, the component name is being used as the title in the `CanvasForm`. This commit uses the corresponding `Title` property if available from components, eips and kamelets, and the `ID` as a last resort. fix: KaotoIO#1462 prerequisite of: KaotoIO#1699
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 16, 2024
Currently, the component name is being used as the title in the `CanvasForm`. This commit uses the corresponding `Title` property if available from components, eips and kamelets, and the `ID` as a last resort. fix: KaotoIO#1462 prerequisite of: KaotoIO#1699
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 16, 2024
Currently, the component name is being used as the title in the `CanvasForm`. This commit uses the corresponding `Title` property if available from components, eips and kamelets, and the `ID` as a last resort. fix: KaotoIO#1462 prerequisite of: KaotoIO#1699
lordrip
force-pushed
the
fix/ensure-viznode-id-2
branch
from
548d4fa to
021c488
Compare
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 16, 2024
Currently, the component name is being used as the title in the `CanvasForm`. This commit uses the corresponding `Title` property if available from components, eips and kamelets, and the `ID` as a last resort. fix: KaotoIO#1462 prerequisite of: KaotoIO#1699
lordrip
force-pushed
the
fix/ensure-viznode-id-2
branch
7 times, most recently
from
18a712f to
f0a3183
Compare
lordrip
commented
Dec 17, 2024
Comment on lines
+38
to
+39
| // Temporary workaround since the toolbar is updated but the config form is closed | ||
| cy.openStepConfigurationTab('setHeader'); |
There was a problem hiding this comment.
This will be handled here: #1869
Currently, when transforming a flow into `VisualizationNodes`, the nodes `Id`s are randomly generated, causing that whenever there's a change in the structure of the flow, previous `Id`s change. This commit uses the `path` + `scope` so the `VisualizationNodes` IDs are stable between interacting with the flow.
lordrip
force-pushed
the
fix/ensure-viznode-id-2
branch
from
f0a3183 to
03e7dfb
Compare
|
lhein
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when transforming a flow into
VisualizationNodes, the nodesIds are randomly generated, causing that whenever there's a change in the structure of the flow, previousIds change.Changes
This commit uses the
path+scopeso theVisualizationNodesIDs are stable between interacting with the flow.