Fix: Navigate to design page on settings save #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamG640
force-pushed
the
Fix_settings
branch
2 times, most recently
from
134aaec to
abb9a3d
Compare
igarashitm
reviewed
Jan 6, 2025
| <SettingsForm /> | ||
| </SettingsProvider> | ||
| </ReloadContext.Provider>, | ||
| <MemoryRouter> |
There was a problem hiding this comment.
It seems this change disturbed sonarcloud and let it complain about an existing duplication. Maybe create a private function to create this React element and let these test cases use it?
There was a problem hiding this comment.
Thanks for the comment @igarashitm. I'll fix this repetition of code!
igarashitm
approved these changes
Jan 6, 2025
shivamG640
force-pushed
the
Fix_settings
branch
from
abb9a3d to
6497d80
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1872 +/- ##
============================================
- Coverage 78.62% 78.44% -0.18%
Complexity 365 365
============================================
Files 439 466 +27
Lines 14234 14682 +448
Branches 2769 2730 -39
============================================
+ Hits 11191 11518 +327
- Misses 2954 3075 +121
Partials 89 89 ☔ View full report in Codecov by Sentry. |
lordrip
approved these changes
Jan 7, 2025
|
Thanks @lordrip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1885
Description
This PR adds the following 2 improvements: