Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(DND): Fix console errors related to DND #1895

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

shivamG640
Copy link
Contributor

Fixes: #1888

Screencast.from.2025-01-08.16-58-28.webm

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (6da8b04) to head (ced3cd7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/Visualization/Custom/Node/CustomNode.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1895      +/-   ##
============================================
- Coverage     78.48%   78.48%   -0.01%     
  Complexity      367      367              
============================================
  Files           468      468              
  Lines         14778    14779       +1     
  Branches       2831     2831              
============================================
  Hits          11599    11599              
+ Misses         3091     2907     -184     
- Partials         88      273     +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bit of blink but I think that's ok for now

@lordrip lordrip merged commit c4f7873 into KaotoIO:main Jan 14, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid flickering of nodes in canvas after a successful DND
2 participants