Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(CanvasForm): Search field not showing correct fields in case of nested fields #1906

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix(CanvasForm): Search field not showing correct fields in case of nested fields #1906

merged 1 commit into from
Jan 15, 2025

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Jan 9, 2025 •
edited
Loading

Fixes #1890

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.70330% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (c4f7873) to head (e31ae88).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/ui/src/components/Form/CustomAutoFields.tsx 62.50% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1906      +/-   ##
============================================
+ Coverage     78.48%   78.49%   +0.01%     
  Complexity      367      367              
============================================
  Files           468      469       +1     
  Lines         14779    14804      +25     
  Branches       2831     2832       +1     
============================================
+ Hits          11599    11621      +22     
- Misses         3092     3095       +3     
  Partials         88       88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivamG640 shivamG640 marked this pull request as ready for review January 14, 2025 10:33
@shivamG640 shivamG640 requested a review from lordrip January 14, 2025 10:33
lordrip
lordrip reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few touches and we're good to go

packages/ui/src/utils/get-filtered-properties.test.ts Outdated Show resolved Hide resolved
packages/ui/src/utils/get-filtered-properties.ts Show resolved Hide resolved
packages/ui/src/utils/get-required-properties-schema.test.ts Outdated Show resolved Hide resolved
@shivamG640 shivamG640 force-pushed the Fix_1890 branch 2 times, most recently from 7ffc322 to 31e0cd8 Compare January 15, 2025 13:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shivamG640 shivamG640 requested a review from lordrip January 15, 2025 14:43
@lordrip lordrip merged commit c6cab16 into KaotoIO:main Jan 15, 2025
13 checks passed
@shivamG640 shivamG640 deleted the Fix_1890 branch January 16, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip Awaiting requested review from lordrip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering nested properties in the form is not working
2 participants
@shivamG640 @lordrip