fix(Canvas): Fix CustomNode rerendering without controller #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
============================================
+ Coverage 78.51% 78.58% +0.06%
Complexity 367 367
============================================
Files 469 468 -1
Lines 14816 14824 +8
Branches 2832 2835 +3
============================================
+ Hits 11633 11649 +16
+ Misses 3095 2904 -191
- Partials 88 271 +183 ☔ View full report in Codecov by Sentry. |
When performing D&D, the following occurs: 1. The graph model gets reset 2. A structural change in the VisualEntity 3. The nodes rerenders 4. There are failuers in the console due to nodes being rerendered without having a controller, because it was removed during the node removal process The first solution for this is to set an empty model to the visualization controller so it removes all nodes from the canvas, then due to the recreation of the visual entities, the canvas will be repopulated. While this works in the browser, when running Kaoto through the Multiplying Architecture, it doesn't work, very likely because of the react versions mismatch (web: 18, MA: 17). The second iteration of the solution is to schedule the entities recreation outside of react, by using `requestAnimationFrame`, this way, the canvas will be cleared before recreating the visual entities. Almost everything boils down to the fact that because the vizNodes are being recreated during the visualization, and since they are stored in the data property of the canvas nodes, the CustomNodes and CustomGroups are being rerendered, due to the use of `observer` from `mobx`. A more future-proof solution would be to remove the `vizNode` objects from the data properties, so the rerendering process occurs without taking those into consideration. fix: KaotoIO#1888
lordrip
force-pushed
the
fix/dnd-related-console-errors
branch
from
cdb4548 to
2d39d36
Compare
lordrip
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When performing D&D, the following occurs:
The first solution for this is to set an empty model to the visualization controller so it removes all nodes from the canvas, then due to the recreation of the visual entities, the canvas will be repopulated.
While this works in the browser, when running Kaoto through the Multiplying Architecture, it doesn't work, very likely because of the react versions mismatch (web: 18, MA: 17).
The second iteration of the solution is to schedule the entities recreation outside of react, by using requestAnimationFrame`, this way, the canvas will be cleared before recreating the visual entities.
Almost everything boils down to the fact that because the vizNodes are being recreated during the visualization, and since they are stored in the data property of the canvas nodes, the CustomNodes and CustomGroups are being rerendered, due to the use of
observerfrommobx.A more future-proof solution would be to remove the
vizNodeobjects from the data properties, so the rerendering process occurs without taking those into consideration.fix: #1888