test DISPLAY envvar

Kappa-Dev · Dec 5, 2024 · b5b54c6 · b5b54c6
1 parent 5d9a371
commit b5b54c6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -248,7 +248,12 @@ jobs:
         export DISPLAY=:99
         sleep 3
     - name: Run Playwright tests
-      run: DEBUG=pw:browser* npx playwright test --retries=2 --trace retain-on-first-failure --project electron
+      run: |
+        echo "start"
+        echo $DISPLAY
+        echo "end"
+        export DISPLAY=:99
+        DEBUG=pw:browser* npx playwright test --retries=2 --trace retain-on-first-failure --project electron
       # run: DEBUG=pw:browser* xvfb-run -e /dev/stdout npx playwright test --retries=2 --trace retain-on-first-failure --project electron
     - uses: actions/upload-artifact@v4
       if: ${{ !cancelled() }}

diff --git a/gui/entry_point/main.js b/gui/entry_point/main.js
@@ -46,6 +46,7 @@ function createWindow() {
   })
 
   mainWindow.once('ready-to-show', () => {
+    // TODO: put this back conditionnally
     // mainWindow.show()
   })
 }

diff --git a/tests/playwright/project_electron_param.ts b/tests/playwright/project_electron_param.ts
@@ -25,9 +25,11 @@ export const test = test_base.extend<TestOptions>({
       console.info("Setting up electron app");
       const electronApp = await electron.launch({
         args: [
-          "--ignore-gpu-blacklist", "--enable-logging",
+          "--ignore-gpu-blacklist",
+          "--enable-logging",
           electron_app_entry_point_path
-        ], executablePath: electron_exe_path
+        ],
+        executablePath: electron_exe_path
       });
 
       // TODO: remove?
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,6 +46,7 @@ function createWindow() { @@
       })
       mainWindow.once('ready-to-show', () => {
+        // TODO: put this back conditionnally
         // mainWindow.show()
       })
     }
@@ Expand Down @@