[pull] master from comfyanonymous:master #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Remove self.device which was useless.
To use: "Load CLIP" node with t5xxl + type mochi "Load Diffusion Model" node with the mochi dit file. "Load VAE" with the mochi vae file. EmptyMochiLatentVideo node for the latent. euler + linear_quadratic in the KSampler node.
* Update web content to release v1.3.21 * nit
* SLG first implementation for SD3.5 * * Simplify and align with comfy style
* Update web content to release v1.3.26 * nit
* Update nodes_images.py Nodes menu has inconsistency in names, some with spaces between words, other not. * Update nodes.py Include the node mapping name line for Image Crop Node * Update nodes_images.py * Rename image nodes add space between words for consistency > Display name mappings
You can still use models/clip but the folder might get removed eventually on new installs of ComfyUI.
* Refactor listuserdata * Full info param * Add tests * Fix mock * Add full_info support for move user file
I think the issue this was working around has been solved. If you notice that this change slows things down or causes stutters on your AMD GPU with ROCm on Linux please report it.
* add fov and mask for load 3d node * some comments
* Update web content to release v1.6.16
* Update web content to release v1.6.17 * Remove js maps
Right click the "Load CLIP" or DualCLIPLoader node and "Show Advanced".
* Add update-frontend github action * Update secrets * nit
Adding yoland and robin to web dir
…ptions to not conflict with the "sigmas" that will overwrite "sigmas" in _calc_cond_batch (#6360)
* Document get_attr and get_model_object * Update model_patcher.py * Update model_patcher.py * Update model_patcher.py
This is required to support some different types of t5 models.
You can now use this node with "edm" selected to control the sigma_max and sigma_min of the Cosmos model sampling.
* Add pyproject.toml * doc * Static version file * Add github action to sync version.py * Change trigger to PR * Fix commit * Grant pr write permission * nit * nit * Don't run on fork PRs * Rename version.py to comfyui_version.py
* Add 'sigmas' to transformer_options so that downstream code can know about the full scope of current sampling run, fix Hook Keyframes' guarantee_steps=1 inconsistent behavior with sampling split across different Sampling nodes/sampling runs by referencing 'sigmas' * Cleaned up hooks.py, refactored Hook.should_register and add_hook_patches to use target_dict instead of target so that more information can be provided about the current execution environment if needed * Refactor WrapperHook into TransformerOptionsHook, as there is no need to separate out Wrappers/Callbacks/Patches into different hook types (all affect transformer_options) * Refactored HookGroup to also store a dictionary of hooks separated by hook_type, modified necessary code to no longer need to manually separate out hooks by hook_type * In inner_sample, change "sigmas" to "sampler_sigmas" in transformer_options to not conflict with the "sigmas" that will overwrite "sigmas" in _calc_cond_batch * Refactored 'registered' to be HookGroup instead of a list of Hooks, made AddModelsHook operational and compliant with should_register result, moved TransformerOptionsHook handling out of ModelPatcher.register_all_hook_patches, support patches in TransformerOptionsHook properly by casting any patches/wrappers/hooks to proper device at sample time * Made hook clone code sane, made clear ObjectPatchHook and SetInjectionsHook are not yet operational * Fix performance of hooks when hooks are appended via Cond Pair Set Props nodes by properly caching between positive and negative conds, make hook_patches_backup behave as intended (in the case that something pre-registers WeightHooks on the ModelPatcher instead of registering it at sample time) * Filter only registered hooks on self.conds in CFGGuider.sample * Make hook_scope functional for TransformerOptionsHook * removed 4 whitespace lines to satisfy Ruff, * Add a get_injections function to ModelPatcher * Made TransformerOptionsHook contribute to registered hooks properly, added some doc strings and removed a so-far unused variable * Rename AddModelsHooks to AdditionalModelsHook, rename SetInjectionsHook to InjectionsHook (not yet implemented, but at least getting the naming figured out) * Clean up a typehint
…6395) Signed-off-by: bigcat88 <[email protected]>
This sampler should work with all models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )