Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38140 - Defer rebooting to "Power Action - Ansible Default" job #11276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hairmare
Copy link
Contributor

What are the changes introduced in this pull request?

This defers the implementation of the reboot action to the "Power Action - Ansible Default" job template.

The current implementation exhibits the following bug on EL9:

ERROR! 'reboot' is not a valid attribute for a Play
The error appears to be in '/tmp/d20250115-157201-nu0y9u/project/playbook.yml': line 1, column 7, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
- reboot:
^ here

Considerations taken when implementing this change?

  • I chose to use a render_template call so the code aligns with the rest of the existing template
  • The other template used in the job is "Run Command - Ansible Default", i picked "Power Action - Ansible Default" because it seems to match

What are the testing steps for this pull request?

  • Configure Foreman/Katello to use Ansible for all actions
  • Install tracer on a host, apply an Errata that needs a reboot
  • Schedule the reboot with the "Reboot host" button and watch the host reboot

@hairmare hairmare marked this pull request as ready for review January 15, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant