Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional stacktrace information for Loggers. #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added additional stacktrace information for Loggers. #166

wants to merge 3 commits into from
+111 −44

Conversation

gethari
Copy link

@gethari gethari commented Oct 17, 2019

Based on this discussion , i have made some changes.

Sorry if my VS settings overridden any code formatting

@Keboo Keboo self-requested a review October 17, 2019 16:30
@Keboo
Copy link
Owner

Keboo commented Oct 25, 2019

@gethari sorry for the long delay.
Take a look at the changes that I pushed to your branch. We are not trying to log the position in the AutoDI course where the errors occurred, instead we are trying to log the position in the source code that AutoDI acts on. That way when these errors/warnings show up in the VS output window the user can simply click on them to navigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keboo Keboo Awaiting requested review from Keboo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gethari @Keboo