Revert back to button role=combobox

Khan · Nov 4, 2024 · a0cbf60 · a0cbf60
1 parent 45abd05
commit a0cbf60
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/wonder-blocks-dropdown/src/components/multi-select.tsx b/packages/wonder-blocks-dropdown/src/components/multi-select.tsx
@@ -545,6 +545,7 @@ export default class MultiSelect extends React.Component<Props, State> {
                             disabled={isDisabled}
                             id={uniqueOpenerId}
                             aria-controls={dropdownId}
+                            placeholder={noneSelected}
                             isPlaceholder={menuText === noneSelected}
                             light={light}
                             onOpenChanged={this.handleOpenChanged}

diff --git a/packages/wonder-blocks-dropdown/src/components/select-opener.tsx b/packages/wonder-blocks-dropdown/src/components/select-opener.tsx
@@ -12,7 +12,7 @@ import caretDownIcon from "@phosphor-icons/core/bold/caret-down-bold.svg";
 import {DROPDOWN_ITEM_HEIGHT} from "../util/constants";
 import {OptionLabel} from "../util/types";
 
-const StyledDiv = addStyle("div");
+const StyledButton = addStyle("button");
 
 type SelectOpenerProps = AriaProps & {
     /**
@@ -161,7 +161,7 @@ export default class SelectOpener extends React.Component<
         ];
 
         return (
-            <StyledDiv
+            <StyledButton
                 {...sharedProps}
                 aria-disabled={disabled}
                 aria-expanded={open ? "true" : "false"}
@@ -188,7 +188,7 @@ export default class SelectOpener extends React.Component<
                     style={styles.caret}
                     aria-hidden="true"
                 />
-            </StyledDiv>
+            </StyledButton>
         );
     }
 }