fix spaceless deprecation #399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 7, 2024
| @@ -36,6 +36,7 @@ public function getFilters(): array | |||
| { | |||
| return [ | |||
| new TwigFilter('knp_menu_as_string', [$this, 'pathAsString']), | |||
| new TwigFilter('knp_menu_spaceless', [$this, 'spaceless'], ['is_safe' => ['html']]), | |||
There was a problem hiding this comment.
Shouldn't we rather deprecate our compressed_root block instead of providing our own spaceless filter suffering from the same shortcomings than the Twig one that has been deprecated because of them ?
There was a problem hiding this comment.
My initial idea was just about making out tests not failing about the twig deprecation, but I didn't manage to get it (using the environment variable SYMFONY_DEPRECATIONS_HELPER didn't work).
If we deprecated our internal block, we'll end up with the same problem (tests failing because of the deprecation)
garak
force-pushed
the
fix-deprecation
branch
from
44a5767 to
cc14a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #395