feat(rpc): handle callback exception #14086
Open
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
reviewed
Jan 7, 2025
| function _M._dispatch(premature, self, cb, payload) | ||
| if premature then | ||
| return | ||
| end | ||
|
|
||
| local res, err = cb(self.node_id, unpack(payload.params)) | ||
| local res, except, err, trace |
There was a problem hiding this comment.
Could we use the return values of xpcall, like https://github.com/Kong/kong/blob/master/kong/clustering/config_helper.lua#L368
There was a problem hiding this comment.
It may be
local ok, res_or_err = xpcall(cb, function(err) ... end, self.node_id, unpack(payload.params))
There was a problem hiding this comment.
I prefer this method. It leaves us more freedom to manipulate the output of the error
StarlightIbuki
force-pushed
the
chore/error-hdl
branch
from
6bcbb4b to
f000cfe
Compare
StarlightIbuki
force-pushed
the
chore/error-hdl
branch
from
f000cfe to
65f3bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAG-6091
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]