feat(clustering/sync): validate deltas #14127
Open
+161
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Water-Melon
approved these changes
Jan 10, 2025
chronolaw
changed the title
chronolaw
reviewed
Jan 10, 2025
| if delta_entity ~= nil and delta_entity ~= ngx.null then | ||
| dc_table[delta_type] = dc_table[delta_type] or {} | ||
|
|
||
| table.insert(dc_table[delta_type], delta_entity) |
|
|
||
| -- table: primary key string -> entity | ||
| if not is_full_sync then | ||
| local schema = kong.db[delta_type].schema |
There was a problem hiding this comment.
localize kong.db in function?
|
|
||
| local foreign_refs = foreign_references[item_type] | ||
|
|
||
| if not item or item == ngx.null or not foreign_refs then |
| local pks = DeclarativeConfig.pk_string(db.schema, v) | ||
| local fvalue = deltas_map[pks] | ||
| if fvalue then | ||
| goto found |
chronolaw
reviewed
Jan 10, 2025
| @@ -506,6 +507,71 @@ local function validate_references(self, input) | |||
| end | |||
|
|
|||
|
|
|||
| function DeclarativeConfig.validate_references_full(self, input) | |||
There was a problem hiding this comment.
Why the parameter is call self? I think that DeclarativeConfig has no method new() to create instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5897