Accept relative URL in the batch controller

Kreyu · Jan 9, 2025 · 07af802 · 07af802
1 parent db1f834
commit 07af802
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/assets/controllers/batch.js b/assets/controllers/batch.js
@@ -97,7 +97,7 @@ export default class extends Controller {
         }
 
         try {
-            href = new URL(identifierHolder.dataset[hrefHolder]);
+            href = new URL(identifierHolder.dataset[hrefHolder], window.location.origin);
         } catch (exception) {
             return;
         }

diff --git a/src/Action/Type/ModalActionType.php b/src/Action/Type/ModalActionType.php
@@ -40,7 +40,7 @@ public function buildView(ActionView $view, ActionInterface $action, array $opti
             }
         }
 
-        $href = $options['href'] ?? $this->router->generate($options['route'], $options['route_params'], RouterInterface::ABSOLUTE_URL);
+        $href = $options['href'] ?? $this->router->generate($options['route'], $options['route_params']);
 
         $view->vars = array_replace($view->vars, [
             'href' => $href,
-Original file line number
+Diff line change
@@ Expand Up / @@ -97,7 +97,7 @@ export default class extends Controller { @@
             }
             try {
-                href = new URL(identifierHolder.dataset[hrefHolder]);
+                href = new URL(identifierHolder.dataset[hrefHolder], window.location.origin);
             } catch (exception) {
                 return;
             }
@@ Expand Down @@