Fix overlapping of action confirmation modals IDs on actions with the…

… same name, but different context
Kreyu · Jan 12, 2025 · 275577d · 275577d
1 parent 2207676
commit 275577d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Action/Type/ActionType.php b/src/Action/Type/ActionType.php
@@ -51,9 +51,10 @@ public function buildView(ActionView $view, ActionInterface $action, array $opti
 
         if ($action->getConfig()->isConfirmable()) {
             $options['confirmation']['identifier'] = vsprintf(
-                format: '%s-action-confirmation-%s',
+                format: '%s-%s-action-confirmation-%s',
                 values: [
                     $dataTable->vars['name'],
+                    $action->getConfig()->getContext()->value,
                     $action->getName(),
                 ],
             );

diff --git a/src/Resources/views/themes/bootstrap_5.html.twig b/src/Resources/views/themes/bootstrap_5.html.twig
@@ -728,7 +728,7 @@
         {% set attr = {
             'class': 'btn btn-primary dropdown-toggle',
             'type': 'button',
-            'id': data_table.vars.name ~ '--row-action--' ~ name ~ '--button',
+            'id': data_table.vars.name ~ '--' ~ context.value ~ '-action--' ~ name ~ '--button',
             'aria-expanded': 'false',
             'data-bs-toggle': 'dropdown',
         }|merge(attr) %}