feat: array source

Kreyu · Oct 5, 2024 · f166304 · f166304
1 parent 4e1153e
commit f166304
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/Query/ArrayProxyQuery.php b/src/Query/ArrayProxyQuery.php
@@ -39,9 +39,9 @@ public function sort(SortingData $sortingData): void
                 $valueB = $propertyAccessor->getValue($b, $propertyPath);
 
                 if ($valueA < $valueB) {
-                    return $direction === 'asc' ? -1 : 1;
+                    return 'asc' === $direction ? -1 : 1;
                 } elseif ($valueA > $valueB) {
-                    return $direction === 'asc' ? 1 : -1;
+                    return 'asc' === $direction ? 1 : -1;
                 }
             }
 
@@ -68,4 +68,4 @@ public function getResult(): ResultSetInterface
             totalItemCount: $this->totalItemCount,
         );
     }
-}
+}
diff --git a/src/Resources/config/core.php b/src/Resources/config/core.php
@@ -74,7 +74,6 @@
         ->tag('kreyu_data_table.proxy_query.factory')
     ;
 
-
     $services
         ->set('kreyu_data_table.proxy_query.factory.doctrine_orm', DoctrineOrmProxyQueryFactory::class)
         ->tag('kreyu_data_table.proxy_query.factory')

diff --git a/tests/Unit/Query/ArrayProxyQueryFactoryTest.php b/tests/Unit/Query/ArrayProxyQueryFactoryTest.php
@@ -36,6 +36,6 @@ public static function provideSupportsCases(): iterable
         yield 'integer' => [123, false];
         yield 'bool' => [true, false];
         yield 'null' => [null, false];
-        yield 'object' => [new \stdClass, false];
+        yield 'object' => [new \stdClass(), false];
     }
 }
diff --git a/tests/Unit/Query/ArrayProxyQueryTest.php b/tests/Unit/Query/ArrayProxyQueryTest.php
@@ -100,4 +100,4 @@ public function testSortAndPaginate()
         $this->assertEquals(1, $result->getCurrentPageItemCount());
         $this->assertEquals(3, $result->getTotalItemCount());
     }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -100,4 +100,4 @@ public function testSortAndPaginate() @@
             $this->assertEquals(1, $result->getCurrentPageItemCount());
             $this->assertEquals(3, $result->getTotalItemCount());
         }
-    }
+    }