display healthy cond on get #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maksymvavilov What does this display if you have no health check? Nothing? |
|
@mikenairn yes. |
maksymvavilov
force-pushed
the
extend-status
branch
2 times, most recently
from
17d492d to
b8a6f2b
Compare
|
there is also a sister PR on the kuadrant side if you are up to it |
philbrookes
reviewed
Jan 14, 2025
| @@ -162,6 +162,7 @@ type DNSRecordStatus struct { | |||
| //+kubebuilder:object:root=true | |||
| //+kubebuilder:subresource:status | |||
| //+kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type==\"Ready\")].status",description="DNSRecord ready." | |||
| //+kubebuilder:printcolumn:name="Healthy",type="string",JSONPath=".status.conditions[?(@.type==\"Healthy\")].status",description="DNSRecord healthy.",priority=2 | |||
There was a problem hiding this comment.
is there a way to make this display something like "unknown" rather than nothing at all, when the field is missing?
There was a problem hiding this comment.
from the kubebuilder side no, but we can always have this condition set to something in the code.
For example if you don't have healthchecks enabled we will have .status.conditions["Healthy"] present and set to "Undefined" or something like it 🤔 I'd prefer not to, however
Signed-off-by: Maskym Vavilov <[email protected]> # Conflicts: # bundle/manifests/dns-operator.clusterserviceversion.yaml
maksymvavilov
force-pushed
the
extend-status
branch
from
b8a6f2b to
0b86180
Compare
philbrookes
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display healthy cond on get
