Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental API Quickstart #156

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

david-martin
Copy link
Member

The quickstart has served its purpose at an earlier stage of the kuadrant project, but is not been progressed passed the experimental stage.
It references older versions of the APIs that are not compatible with v1.
Let's remove it.

Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit 66d214f
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/675bfff8e1a3be000879d5c0
😎 Deploy Preview https://deploy-preview-156--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@david-martin
Copy link
Member Author

@jasonmadigan I'd like to cherrypick this removal to the v1 branch as well because it references older APIs.

@jasonmadigan
Copy link
Member

/lgtm

@david-martin
Copy link
Member Author

/cherry-pick v1.0.x

@openshift-cherrypick-robot

@david-martin: only Kuadrant org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick v1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@david-martin
Copy link
Member Author

/cherry-pick v1.0.x

@openshift-cherrypick-robot

@david-martin: once the present PR merges, I will cherry-pick it on top of v1.0.x in a new PR and assign it to you.

In response to this:

/cherry-pick v1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@david-martin david-martin force-pushed the remove-experimental-api branch from c94c166 to c2347d9 Compare December 12, 2024 14:47
@openshift-ci openshift-ci bot removed the lgtm label Dec 12, 2024
@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 12, 2024
@jasonmadigan jasonmadigan removed the lgtm label Dec 12, 2024
@jasonmadigan
Copy link
Member

We can prob remove the api-quickstart import:

name: api-quickstart
          import_url: 'https://github.com/kuadrant/api-quickstart?edit_uri=/blob/main/&branch=main'
          imports:
            - /README.md
            - /images/*

@david-martin david-martin force-pushed the remove-experimental-api branch from c2347d9 to 66d214f Compare December 13, 2024 09:35
@david-martin
Copy link
Member Author

We can prob remove the api-quickstart import:

Done

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d409d44 into main Dec 13, 2024
9 checks passed
@openshift-cherrypick-robot

@david-martin: new pull request created: #157

In response to this:

/cherry-pick v1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jasonmadigan jasonmadigan deleted the remove-experimental-api branch December 13, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants