-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental API Quickstart #156
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-martin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for graceful-kangaroo-3c9c10 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@jasonmadigan I'd like to cherrypick this removal to the v1 branch as well because it references older APIs. |
/lgtm |
/cherry-pick v1.0.x |
@david-martin: only Kuadrant org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick v1.0.x |
@david-martin: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c94c166
to
c2347d9
Compare
/lgtm |
We can prob remove the api-quickstart import:
|
Signed-off-by: David Martin <[email protected]>
c2347d9
to
66d214f
Compare
Done |
/lgtm |
@david-martin: new pull request created: #157 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The quickstart has served its purpose at an earlier stage of the kuadrant project, but is not been progressed passed the experimental stage.
It references older versions of the APIs that are not compatible with v1.
Let's remove it.