Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build checks to prs to branches beginning with v #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laurafitzgerald
Copy link
Contributor

No description provided.

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laurafitzgerald
Once this PR has been reviewed and has the lgtm label, please assign mikenairn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit ffb682d
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/678a53b2fce86400087a5112
😎 Deploy Preview https://deploy-preview-180--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only want this workflow on the main branch as it runs a mike deploy --push dev -t "dev" (pushes the most up to date docs on main as the 'dev' version)

For release branches, there's a manual run of the action, which runs through the various build steps before deploying that specific version.

@jasonmadigan Can you sanity check this is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants