Deprecate workload selectors?

[alexsnaps]

I think with this being introduced in Istio 1.20

In this release, we have also added support for configuring Istio CRDs AuthorizationPolicy, RequestAuthentication, Telemetry and WasmPlugin for Kubernetes Gateway API via the targetRef field.

We might be able to leverage targetRef'ing the Gateway directly in our code just as well.

[eguzki]

This would set Istio 1.20 as a clear minimum requirement for kuadrant. Meaning that kuadrant would not work as expected with any Istio release prior to 1.20 version.

[KevFan]

WasmPlugin has been updated to use targetRef as part of https://github.com/Kuadrant/kuadrant-operator/pull/612/files

Similar can be done to AuthorizationPolicy at:

kuadrant-operator/controllers/authpolicy_istio_authorizationpolicy.go

Lines 90 to 105 in 6823ed0

	iap := &istio.AuthorizationPolicy{
	ObjectMeta: metav1.ObjectMeta{
	Name: IstioAuthorizationPolicyName(gateway.Name, ap.GetTargetRef()),
	Namespace: gateway.Namespace,
	Labels: istioAuthorizationPolicyLabels(client.ObjectKeyFromObject(gateway), client.ObjectKeyFromObject(ap)),
	},
	Spec: istiosecurity.AuthorizationPolicy{
	Action: istiosecurity.AuthorizationPolicy_CUSTOM,
	Selector: kuadrantistioutils.WorkloadSelectorFromGateway(ctx, r.Client(), gateway),
	ActionDetail: &istiosecurity.AuthorizationPolicy_Provider{
	Provider: &istiosecurity.AuthorizationPolicy_ExtensionProvider{
	Name: KuadrantExtAuthProviderName,
	},
	},
	},
	}