-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target ref #691
Target ref #691
Conversation
- Added TargetRef to AuthPolicy to specify the target reference. - Replaced the gateway object with the gateway wrapped inside the gatewayWrapper. - Fixed various errors and improved code formatting. - Resolved issues with Istio integration tests. This commit consolidates multiple changes made during the development process, improving the stability and functionality of the AuthPolicy controller and related tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed user guide https://github.com/Kuadrant/kuadrant-operator/blob/main/doc/user-guides/auth-for-app-devs-and-platform-engineers.md and was working as expected 👍
Also checked the target ref of the AuthorizationPolicies
You need to rebase on top of latest |
…- Added TargetRef to AuthPolicy to specify the target reference. - Replaced the gateway object with the gateway wrapped inside the gatewayWrapper. - Fixed various errors and improved code formatting. - Resolved issues with Istio integration tests. This commit consolidates multiple changes made during the development process, improving the stability and functionality of the AuthPolicy controller and related tests.
Using PolicyTargetReference instead of Selector for authpolicy_controller
closes issue : #302
Verification Steps
make local-setup
kubectl apply -f examples/toystore/kuadrant.yaml
kubectl apply -f examples/toystore/toystore.yaml
Check the Status of 'AuthPolicy' resources:
kubectl get authpolicy -A
Detailed status Verification:
kubectl get authpolicy -n istio-system gw-1 -o yaml
kubectl get authpolicy -n default toystore -o yaml
Check events for AuthPolicies:
kubectl describe authpolicy -n istio-system gw-1
kubectl describe authpolicy -n default toystore
Should output both of these for each auth-policy