Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer in parentRef namespace dereference #335

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

adam-cattermole
Copy link
Member

If the parentRef.Namespace does not exist we crash loop trying to locate the gateway namespace. If it does not exist it should be in the namespace of the HTTPRoute.

Fixes #333

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #335 (6caea70) into main (cb9d3d5) will increase coverage by 0.60%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   64.44%   65.05%   +0.60%     
==========================================
  Files          35       35              
  Lines        3794     3794              
==========================================
+ Hits         2445     2468      +23     
+ Misses       1156     1131      -25     
- Partials      193      195       +2     
Flag Coverage Δ
unit 59.50% <100.00%> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <100.00%> (+2.99%) ⬆️
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 69.94% <ø> (ø)
Files Coverage Δ
pkg/common/gatewayapi_utils.go 68.23% <100.00%> (+5.41%) ⬆️

@adam-cattermole adam-cattermole marked this pull request as ready for review November 24, 2023 14:53
@adam-cattermole adam-cattermole requested a review from a team as a code owner November 24, 2023 14:53
@adam-cattermole adam-cattermole merged commit 050f417 into Kuadrant:main Nov 24, 2023
15 checks passed
maleck13 pushed a commit to maleck13/kuadrant-operator that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: To test
Development

Successfully merging this pull request may close these issues.

Operator crash loops on RLP targetting HTTPRoute with no namespace in parentRef
3 participants