fix integration tests: wait for route to be accepted #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 65.28% 65.70% +0.42%
==========================================
Files 35 35
Lines 3794 3797 +3
==========================================
+ Hits 2477 2495 +18
+ Misses 1123 1114 -9
+ Partials 194 188 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eguzki
force-pushed
the
fix-rlp-integration-tests
branch
from
b8ac79d to
eb230e8
Compare
eguzki
changed the title
eguzki
changed the title
eguzki
commented
Nov 26, 2023
| @@ -282,6 +272,7 @@ var _ = Describe("AuthPolicy controller", func() { | |||
| } | |||
| err = k8sClient.Create(context.Background(), otherRoute) | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| Eventually(testRouteIsAccepted(client.ObjectKeyFromObject(otherRoute)), time.Minute, 5*time.Second).Should(BeTrue()) | |||
There was a problem hiding this comment.
maleck13
approved these changes
Nov 27, 2023
I was thinking exactly the same. |
|
I run the integration tests few times and they did not fail. Hopefully, no more flaky tests for a while at least
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.